Skip to content

Admit Sample's read-only PHP launcher for its existing callers - #408

Merged
rmcdaniel merged 1 commit into
mainfrom
general/sample-app-php-ci-readonly-admission
Nov 17, 2026
Merged

rmcdaniel merged 1 commit into
mainfrom
general/sample-app-php-ci-readonly-admission

Conversation

@rmcdaniel

Copy link
Copy Markdown
Member

Sample App PR durable-workflow/sample-app#349 (exact head f069b118886f922e979d865d964ed5179b9bc3dc, Refs durable-workflow/sample-app#344) mounts the checkout and wrapper state read-only and makes only named data/cache/output paths writable. Its CI run fails the central preflight because the writable Sample runtime record was withdrawn in #389 and nothing replaced it. This draft adds the exact replacement record. Every existing catalog value and the policy implementation stay unchanged.

Record (qualification/composer-container-trust.json)

  • sample-app-php-ci: ci.yml jobs test and microservice-test, literal matrix php: ['8.4', '8.5'], matrix setup command only.
  • sample-app-php84-ci: composer-lock-audit.yml audit and playground-journeys.yml journeys, literal "8.4" setup command only.
  • Both bind the same 12 files by SHA-256 and canonical Git mode (the f069b118 launcher, setup and TLS test, plus the unchanged image inputs) and require docker/php-ci/Dockerfile.dockerignore to be absent. This is the same file set as the retired record. Only the three files Adopt the exact manual Ubuntu 24 PHP qualification workflow #349 changed have new hashes.
  • The preflight checks every sample-app workflow (composer_trust_required). A record for ci.yml alone would still refuse at composer-lock-audit.yml:audit:step-6, so the 8.4 callers are included. They are split out so a literal 8.4 command cannot be admitted in ci.yml, and the matrix command cannot be admitted in the 8.4 callers.

Controls (SampleAppReadOnlyRuntimeContractTest, which runs in the existing CI module)

  • The recorded launcher and setup hashes equal the vendored f069b118 bytes. The vendored 799df847 bytes equal the retired record.
  • The exact caller fixtures enumerate all five guarded requests.
  • These all refuse: the retired writable launcher or setup, the launcher with its root mount made writable, any changed bound file, a non-executable launcher, and a present Dockerfile.dockerignore.
  • These also refuse: another target, job or workflow, a swapped literal or matrix command, an extended or include matrix, an unguarded extra job, a conditional, ignored or env-overridden setup, a removed live verifier, and a job-level runtime env override.

Validation

  • Focused modules (test_composer_trust_contract, test_composer_container_trust, test_qualification_policy, test_cli_phar_runtime, test_cli_php_reference_runtime): 206 tests OK in python:3.13-slim.
  • Full CI Python module list plus the CLI runtime modules on lab4: 896 tests. The only failure is a pre-existing host pip-version assertion that main also has.
  • scripts/qualification_policy.py validate --target sample-app passes against the sample-app tree at f069b118 and refuses 799df847 (Reviewed Composer runtime source differs: scripts/ci/run-php-container.sh).

Stops

🤖 Generated with Claude Code

Bind the exact sample-app f069b118 PHP CI runtime source (12 files by
SHA-256 and Git mode, plus the per-Dockerfile ignore absence) for its
existing callers only: ci.yml test and microservice-test on the literal
PHP 8.4/8.5 matrix, and the 8.4 setup in composer-lock-audit.yml audit
and playground-journeys.yml journeys. The preflight validates every
sample-app workflow, so all four callers need the same launcher record.

The retired writable record stays withdrawn; its launcher bytes refuse.
Fixtures copy the three caller workflows, the audit request helper and
the reviewed and retired launcher pairs for the focused controls.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@rmcdaniel rmcdaniel added the agent:general Pull request opened by General agent label Nov 17, 2026
@rmcdaniel

Copy link
Copy Markdown
Member Author

General review of head 2160a27d: PASS (Security agent off; General covers its review).

  • Two narrow records:
    • sample-app-php-ci: ci.yml jobs test and microservice-test, PHP 8.4/8.5 matrix setup command only.
    • sample-app-php84-ci: composer-lock-audit.yml audit and playground-journeys.yml journeys, fixed 8.4 only.
    • Each pins the same 12 files by sha256 and Git mode and requires docker/php-ci/Dockerfile.dockerignore to be absent. No existing entry or policy code changes.
  • I independently recomputed the bound hashes from sample-app f069b118 (Adopt the exact manual Ubuntu 24 PHP qualification workflow #349, which has Security source PASS): run-php-container.sh f4030f58…, setup-php-container.sh 051301e9…, test_php_container_tls.py 673e53e9…, docker/php-ci/Dockerfile dcdd1e2f…, .dockerignore 3d3b99f9…, php-container-images.json fc4d4105…. All match, and the dockerignore is absent.
  • Negative controls refuse the withdrawn writable launcher (799df847), a writable root mount, any changed bound file, other jobs or workflows, swapped or overridden setup commands and a removed verifier. Locally, 206 focused tests pass and qualification_policy.py validate --target sample-app passes at f069b118.
  • Runtime evidence: sample-app run 44124778705 shows all four PHP cells running through the read-only launcher and composer install. They fail only at the known Laravel advisory that sample-app#346 fixes.

Marking ready for normal checks and merge.

@rmcdaniel
rmcdaniel marked this pull request as ready for review November 17, 2026 16:35
@sonarqubecloud

Copy link
Copy Markdown

@rmcdaniel
rmcdaniel merged commit 6994185 into main Nov 17, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:general Pull request opened by General agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant